Wild Minion RA...

[Yemla]

• Wild Minion
  Increases chance of pet dealing a critical hit in melee by the listed percentage.
  1. 3%
  2. 9%
  3. 17%
  4. 27%
  5. 39%

In PropertyChangingSpell.CS under PetBuff section (in it)

Code: Select all

if (effect.Owner is GameNPC)
{
if ((effect.Owner as GameNPC).Brain is ControlledNpcBrain)
{
RealmAbilities.L3RAPropertyEnhancer wildminion = ((effect.Owner as GameNPC).Brain as IControlledBrain).GetPlayerOwner().GetAbility(typeof(RealmAbilities.WildMinionAbility)) as RealmAbilities.L3RAPropertyEnhancer;
if (wildminion != null)
{
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalArcheryHitChance] += wildminion.Amount;
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalHealHitChance] += wildminion.Amount;
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalMeleeHitChance] += wildminion.Amount;
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalSpellHitChance] += wildminion.Amount;
}

i remember Wild Minion being Crit chance for healing,archery,melee, magic for pets but anyway anyone else believe this will work? i can't test atm but if not i know away of a fersure slopy code to have it work look

Code: Select all

if (wildminion != null)
{
switch (wildminion.Level)
{
case 1:
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalArcheryHitChance] += 3;
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalHealHitChance] += 3;
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalMeleeHitChance] += 3;
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalSpellHitChance] += 3;
break;
case 2:
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalArcheryHitChance] += 9;
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalHealHitChance] += 9;
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalMeleeHitChance] += 9;
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalSpellHitChance] += 9;
break;
case 3:
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalArcheryHitChance] += 17;
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalHealHitChance] += 17;
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalMeleeHitChance] += 17;
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalSpellHitChance] += 17;
break;
case 4:
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalArcheryHitChance] += 27;
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalHealHitChance] += 27;
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalMeleeHitChance] += 27;
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalSpellHitChance] += 27;
break;
case 5:
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalArcheryHitChance] += 39;
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalHealHitChance] += 39;
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalMeleeHitChance] += 39;
(effect.Owner as GameNPC).AbilityBonus[(int)eProperty.CriticalSpellHitChance] += 39;
break;
}
}

[stephenxpimentel]

first 1 looks good to me, definitely not the second one, double hard-coding values isn't pretty.

[Yemla]

if not i know away of a fersure slopy code to have it work look

first 1 looks good to me, definitely not the second one, double hard-coding values isn't pretty.

totally agree'd x]

[Graveen]

The 1 is nice yes.

Anyway, i remember melee but does it targets heal, archery & spell damages ? not sure.

You can commit the 1 btw, thank you !

[Yemla]

im going to commit the first part with just melee part (considering we are unsure about magic/healing/archery) x] atleast tell someone shows/says different...

[Sand]

I always thought it was mele only.

Here is mythic's description of the ability (if that helps given how reliable their information can be )

"Increases chance of pet dealing a critical hit in melee by the listed percentage."

[Yemla]

I agree sand but, im going to log into pendragon in a bit and double check...sometimes mythic updates spells/ra/style without updating there information on the herald O.o im pretty sure its only melee as well...