XP_Group_Cap_Percent don't work

[Enzo]

Hi, I think the XP_Group_Cap_Percent property don't work.
I have set it to 0 but in game I gain XP as Group Experience. And if I change the value, the XP is the same.

Any help on how I can remove the Group Bonus XP?
Thanks in advice!

[ontheDOL]

here is the code behind it...

Code: Select all

if (player != null)
{
expCap = (long)(GameServer.ServerRules.GetExperienceForLiving(player.Level) * ServerProperties.Properties.XP_CAP_PERCENT / 100);

if (player.Group != null && isGroupInRange)
{
// Optional group cap can be set different from standard player cap
expCap = (long)(GameServer.ServerRules.GetExperienceForLiving(player.Level) *
ServerProperties.Properties.XP_GROUP_CAP_PERCENT / 100);
}
}

its not really optimal coding here..
basically, if you want have a higher xp cap while in a group, it can be set here. If you want it the same as normal xp cap, you should leave it the same value as XP_CAP_PERCENT

Although i think you are saying you are receiving xp as group experiece all the time, which i believe has nothing to do with this GROUP_CAP_PERCENT, but rather some errors in the code around, where players receive group bonus if they are in a group, rather than group bonus from killing mobs that have BAF'd (bring a friend) as it was like on live.

[PlanarChaosRvrtwo]

I think he refers to wrong grp bonus that means you get xp as grp xp as long you are grped and not as long mobs run in grps for you.

[Enzo]

I am telling that I need a way to remove the XP group bonus. If I change the XP_GROUP_CAP_PERCENT the same value of XP_CAP_PERCENT, or even if I change it to 0, if I am in a group I still gain a Xp group bonus.


For example: "You get 30 experience points. (20 group bonus)".
Can I lower the (20 group bonus) or even remove it?

[ontheDOL]

like i said at the bottom of my post, the problem you are referring to is an error in the way it is coded, where DOL gives you 'group bonus' xp purely for being in a group, rather than how it should be, only from mobs that BAF'd

If you want to remove it, you need to edit the code and fix it I could fix it in a pull request but likely you wouldnt see that change merged for many months

#edit sorry this probably isnt the response you want to hear, but unfortunately this really is the state of DOL right now

[Enzo]

Thanks for the explanation.

No problem, thank you for your time.

[ontheDOL]

i can probably give you a server version with this changed,( i think maybe you were the one i gave an older version with npctemplates fixed)

hit me up on discord and i will see if i can help

[Enzo]

Yes, it was me, it was not the npctemplate but that the server when started overwrites the stats of the mobs with the autoset stats. That was a problem for my server

For the group xp it's not a problem, thanks!

[Shursan]

as i remember,

Group XP Percent is not really what it should be.
Here dol do it like: if you get a group, you get a group bonus, but it's not really like this it should be coded.

What is intended is to have mob baff giving group bonus when linking. that's really not the same type of things you get here.

Maybe a day, a fix will come on this. Im working hard on exp frame actually, i need somes values from live for modify challenge exp code distributions depending on how many groups members and con value from the mob.
I will try exp baffing system bonus after this one.