Casting and Interruption

[skud]

So I noticed on our server that it seemed like casters could often cast through melee attacks without getting the interrupt message. So I did some investigating, and found out that there is a spelling error. Uninterruptable should be Uninterruptible. Also, the warlock spell for the uninterruptible need to be changed from Uninterruptable to Uninterruptible under type. After applying these changes, everything was working perfectly. Files that need to be changed are: GamePlayer.cs, BuffShear.cs, SpellHandler.cs, PowerlessHandler.cs,RangeSpellHandler.cs,UninterruptableSpellHandler.cs. Correct me if I am wrong, but my guess is this was just a spelling mistake.

[Dunnerholl]

i cant see how that would change anything. its consistently misspelled, and if u consistently rename it, what changes?

[skud]

it was misspelled to the point that it was not calculating the interrupt code correctly for when casting a spell.

[Graveen]

Can you post the patch to allow us to see where it is processed and why ?

[nor]

Btw it is a good idea to use constants in such cases when several places need to reference single logical unit. Even if a constant is used in one place it is still a good thing/positive change. I remember there were a lot of strings all around the code which is error-prone.

Perhaps there are even some tools to do that. Never needed one though.

[Graveen]

totally right nor

i have this in my bookmarks for a long time, perhaps could help if anyone is ok to do the job http://www.knowdotnet.com/articles/inse ... ticle.html.

I would think a bit the change, as in this case this shounds obviously shared between pure constant and localized string, and could belong to LangMgr.

But this is important to split distinctly the localisation strings and code variables, as they are aimed to totally different things.

[skud]

yeah ill make it into a patch.

[Graveen]

Thx !

[Etaew]

For the temporary property keys you don't have to worry about localisation graveen, the code is in english, and so can the keys be as nor says, the constant should be used here