[accepted] WrathOfChampions Fix

[LifeFlight]

Currently Phaseshifted players could take damage from WoC, and this is not correct.

Code: Select all

Index: WrathOfChampionsAbility.cs
===================================================================
--- WrathOfChampionsAbility.cs (revision 1563)
+++ WrathOfChampionsAbility.cs (working copy)
@@ -6,6 +6,7 @@
using DOL.GS.Effects;
using DOL.Events;
using DOL.Database;
+using DOL.GS.Spells;

namespace DOL.GS.RealmAbilities
{
@@ -56,6 +57,15 @@
if (GameServer.ServerRules.IsAllowedToAttack(player, t_player, true) == false)
continue;

+ //Check to see if the player is phaseshifted
+ GameSpellEffect phaseshift;
+ phaseshift = SpellHandler.FindEffectOnTarget(t_player, "Phaseshift");
+ if (phaseshift != null)
+ {
+ player.Out.SendMessage(t_player.Name + " is Phaseshifted and can't be effected by this Spell!", eChatType.CT_SpellResisted, eChatLoc.CL_SystemWindow);
+ continue;
+ }
+
if (!player.IsWithinRadius( t_player, 200 ))
continue;
t_player.TakeDamage(player, eDamageType.Spirit, dmgValue, 0);

[Graveen]

Accepted, soon in SVN, thank you

I wonder why the Zephyr/PhaseShift related checks are not handled in serverrules. Is anyone seeing a case were it should not be handled in IsAllowedToAttack() directly ?

[LifeFlight]

Well, from Live I remember that FZ and PS didn't not allow attacks, everything just resisted.

You could still spam nukes or w/e on a phaseshifted target, as well as cast on a FZ target (You could spam theurg pets so the moment they dropped out of it they have 15 or so on them).

So it's not that you can't attack them, it's just that nothing hits them.

[Graveen]

Ok, thx.