Dawn of Light

Commit from matt450

Log Messages
Changed: Proc handling change, if item model is Bruiser (model 1671/2113), allow procs to fire on keep components and keep doors.

Files Changed:
MODIFY - DOLSharp/trunk/GameServer/gameobjects/GameLiving.cs

View Changes:
http://dolserver.svn.sourceforge.net/do ... v&rev=3096

I totally understand the quickfix, but it should not be done in this way, the model is a too generic base from a shard to another.

What i suggest:
- create a new blank class inheriting from GameInventoryItem (or ItemTemplate, w/e is suitable)
- perform this check in regard of this new class

/wave

I thought about that briefly, kinda figured it was overkill to make a class for this specific item, so I went with the model, I'll change it and get it committed sometime today. I was going to use a check for the name Bruiser, but figured that wasn't very universal in terms of language since Bruiser might translate to something different in another language.

With the class, you can also extend it to handle an effect, a specific sound, a complex trigger ( you hit with the sword of betrayal ? you are teleported to the Lord).

Another possible way is to rule it with a serverproperty, but this is a quick fix too - but more acceptable than an hardcoded one.

Created the class, tested and committed, asterick pointed out to me that this will work for the Fools Bow also, I'll have to take a look at the proc on that one (if it has one).

Taking another look at this after a bit of a break....since the object class thing was a bit complicated, can we just use a flag in ItemTemplate, say, 10 (can't find any instances of this number being used anywhere else), to allow procs to fire on keepcomponents?

Code: Select all

public override bool AllowWeaponMagicalEffect(AttackData ad, InventoryItem weapon, Spell weaponSpell)
{
if (weapon.Flags == 10)
return true
else return false; // special code goes here
}

it's better, but, what is the problem with a new class inheriting from itemtemplate ?

The new class won't apply to artifacts, when the server starts up, ArtifactMgr references the Artifact and ArtifactXItem table and all the artifacts in players inventories become InventoryArtifact objects. The class on the Bruiser ItemTemplate was changed to DOL.GS.GameSiegeItem, but the class doesn't carry over when the server starts up.

I think flags are fine for now, with a comment about artifacts included. If or when artifacts are re-written to use the new items types then the code for these can change. Dealing with legacy crap here.