Dawn of Light

Added effect to Archery.
I've tested this. Damage seems pretty close to correct. In any case resist pierce effect is now working for Archery.

That does not do what you intended to do.

if (resiPierce > 0 || resiPierce > 0 && ad.AttackType == AttackData.eAttackType.Spell && Spell.SpellType == "Archery")

Not grouped correctly, since it mixes AND and OR, but regardless this will always be true if resiPierce > 0

What you need to do here is discover when you don't want to execute this code and then make logic for it. Perhaps it should always happen?

As far as I can recall Spell Pierce effected all magic damage in forms of spells/proc/charges..so I reverted this back and tested simply as:

Code: Select all

if (resiPierce > 0)

I got the same results as before...increased damage, so it worked as Geshi had pointed out in the other thread, not sure what had happened last time for me but it was a late night, I probably had missed something and never realized it.