Page 1 of 7

[Roadmap] DOL to 1.115 Client Support and Fix Merge

PostPosted: Fri Aug 29, 2014 9:16 am
by Leodagan
Identified Changes Needed for 1.115
  • Eden Packet Change ~1.110 to ~1.114
  • Packet Change and Warmap change for ~1.115
  • NPC Update Rate and Player Update Rate Change (about ~10sec NPC, about ~1 sec player)
  • Keep Manager able to handle warmap instead of PacketLib to allow more Abstract Keep Code (thus allowing for custom manager for new New New Frontiers Rules)
  • Portal Ceremony NPC for New Reinforcement System
  • New Steed Speed about the same as Bard/Skald/Minstrel (ServerProperty Switch ? Only in Frontiers ?)
  • New Agramon Keep(Tower?) / Miles Gate handling (not researched...)
  • Dock Capture, Relic Encounter, Minotaur Relic change (not researched...)
  • World Build, Frontiers village update, Mobs Spawn Update (could be fix with some packet logging)
Current Implementation
  • 3329 - First PacketLib Implementation for 1.115 (fix to Item Data for Inventory Garbage...)
  • 3330 - Portal Ceremony Base, can be easily used to implement New New Frontiers Rules (Ceremony Speed need to be researched...)
  • 3337 - Auto Registering of GSS DataObject Tables, needed for GSS Keep Manager implementation to switch between Legacy and NNF at will !
  • 3338 - Adding pre-implementaiton of new World update thread to allow for sending server-made Player packet and handle different object refresh rate with current updates.
Fixes and Merge
  • Various Eden Fix to locking trouble (not inventoried)
  • Freyad Fixes for Packet Libs (Mostly using statement for disposable object, some properties fixed, some comments and readability improvement, need to make a diff inventory)
  • Keep Manager Abstraction and maybe many other abstraction to allow for easier replacement in GSS, keeping the core with a lower amount of code (easier maintenance) and allowing to slowly replace Legacy parts with enhanced scripts.
Current Merge
  • 3319 - latest Eden Branch.
  • 3333 - merge with DOL trunk at Jan. 2014 (WIP)
  • 3339 - latest Freyad Branch.
  • 3344 - Working version 1.115 merge with Freyad, getting Eden PlayerPosition Update Handler.

Re: [Roadmap] DOL to 1.115 Client Support and Fix Merge

PostPosted: Fri Aug 29, 2014 10:47 am
by Graveen
Thank you, this is very good. Notice the 3333 is only merging on a separate branch, not in the trunk (so actually the core is not running Eden fixes, except the one you ported).

Re: [Roadmap] DOL to 1.115 Client Support and Fix Merge

PostPosted: Fri Aug 29, 2014 11:37 am
by Leodagan
I made a First Big Merge Between My Packet Code and Trunk.

This allowed me to import my own 1.110+ implementation, with which I tried to rely as much possible on current code, where Darwin added a lot of "Cache Table" this may give the ability to current code to be able to run in v1.115 mode right away...

I warned that revision 3341 should not be used for production use...

But I'm expecting to finish the merge between this one, and the previous World Update Thread pre-commit before the end of the day ;)

Re: [Roadmap] DOL to 1.115 Client Support and Fix Merge

PostPosted: Fri Aug 29, 2014 1:14 pm
by Graveen
/worship !!! :)

Re: [Roadmap] DOL to 1.115 Client Support and Fix Merge

PostPosted: Fri Aug 29, 2014 5:00 pm
by Leodagan
Revision 3344 include :

Abstracted Keep Object (Interface).
Database default Timefield.
PacketLib Revamp and Update up to 1.115.
WorldUpdateThread Revamp, Lightly tested. (including some fixes to instances)
AutoRegistration of Script DataObject.

Fully fuctional with latest Storm Revision.

Be Careful I had to change the MySQL driver for a more recent, I had trouble on Table Altering for the default Time field !

With this Storm can now handle 1.115 clients, but the serverproperty : WORLD_NPC_UPDATE_INTERVAL must be set to 10 000ms

Re: [Roadmap] DOL to 1.115 Client Support and Fix Merge

PostPosted: Fri Aug 29, 2014 5:16 pm
by Tolakram
So have you tried running with players yet? Will Storm be the first to do that?

Re: [Roadmap] DOL to 1.115 Client Support and Fix Merge

PostPosted: Fri Aug 29, 2014 5:59 pm
by Leodagan
Only in Local, with multiple player account spawned on my computers...

I have no idea how to test it large scale :)

Re: [Roadmap] DOL to 1.115 Client Support and Fix Merge

PostPosted: Fri Aug 29, 2014 7:05 pm
by Tolakram
Me either :) We can restart storm to apply the new code, auto restart was this morning, next restart is Sunday morning.

Re: [Roadmap] DOL to 1.115 Client Support and Fix Merge

PostPosted: Fri Aug 29, 2014 8:40 pm
by Leodagan
Someone should watch for Storm restart !!

the serverconfig.xml could need a connection string with something like :
Code: Select all
Default Command Timeout=0;
for the LastUptated time field add...

And I definitely had some trouble with the old Mysql DLL, and the new one could need to use the connection string with the most recent syntax...

For my part I used this :
Code: Select all
<DBConnectionString>server=localhost;port=3306;database=livedol;User Id=root;password=;Treat Tiny As Boolean=False;Minimum Pool Size=10;Maximum Pool Size=20;Cache Server Properties=True;Default Command Timeout=0;</DBConnectionString>

Re: [Roadmap] DOL to 1.115 Client Support and Fix Merge

PostPosted: Fri Aug 29, 2014 10:03 pm
by Tolakram
k.

I have long weekend here and it's hot and miserable out so I should have time to babysit a restart.

Re: [Roadmap] DOL to 1.115 Client Support and Fix Merge

PostPosted: Sat Aug 30, 2014 1:11 pm
by Leodagan
I'll be available around 8h00 to 19h00, maybe not always near the screen ;)

I've started working around keep manager this morning, as this will be the big trouble with the 1.115 NNF.

The Current IKeepManager Interface is way too specialized !!

it relies on Hashtable and AbstractGameKeep, where I think it should reference Collections like "IDictionnary" or "Ilist" or "ICollection" and all Keep references should be based on "IGameKeep" or "IGameKeepComponent" I don't know why there is battleground references in this, Abstract Game Keep doesn't use IKeepManager abstraction but rely directly on DefaultKeepManager Properties...

I'm doing everything to keep legacy code working, but if it doesn't follow it's own interfaces I don't know if it'll be maintained in the future...

Re: [Roadmap] DOL to 1.115 Client Support and Fix Merge

PostPosted: Sat Aug 30, 2014 2:59 pm
by Tolakram
Looks like Storm restarted this morning and timed out. Changing the settings and trying again.

Re: [Roadmap] DOL to 1.115 Client Support and Fix Merge

PostPosted: Sat Aug 30, 2014 3:17 pm
by Tolakram
Storm is up. I'm installing the latest SharpDevelop and .NET 4.5 so I can build, then I need to install the portal, and then I'll test the latest client to see how it works.

Re: [Roadmap] DOL to 1.115 Client Support and Fix Merge

PostPosted: Sat Aug 30, 2014 3:43 pm
by Tolakram
Woot.

Connected to Storm via portal and 1.115, set NPC update interval to 10000, player was already at 1000. Everything seems to be working well. I need to remove a debug line in delve since it spams delve when tooltips are refreshed.

Re: [Roadmap] DOL to 1.115 Client Support and Fix Merge

PostPosted: Sat Aug 30, 2014 3:52 pm
by Leodagan
And you doubted me :D

I don't have easy fixes for Tooltips actually, Darwin used a lot of hardcoded value to implement these, but I really don't like that :)