Dawn of Light

SVN 3388 , Client 1.109

I reviewed log files and I found this error multipe times.

I asked the players related, but they said no problem.

What is related with this error ? How trigger it ?

Code: Select all

23:59:54,087 - [22] - ERROR - DOL.GS.PacketHandler.PacketProcessor - Error while processing packet (handler=DOL.GS.PacketHandler.Client.v168.DetailDisplayHandler client: Version1109 pakLib:DOL.GS.PacketHandler.PacketLib1109 type:LabyrinthOfTheMinotaur(LabyrinthOfTheMinotaur) addons:bit4, bit5, Foundations, NewFrontiers state:Playing IP:175.210.242.20:49205 session:55 acc:ldespair1 char:Thane class:21) System.FormatException: Index (zero based) must be greater than or equal to zero and less than the size of the argument list. at System.Text.StringBuilder.AppendFormat(IFormatProvider provider, String format, Object[] args) at System.String.Format(IFormatProvider provider, String format, Object[] args) at System.String.Format(String format, Object[] args) at DOL.GS.Spells.AblativeArmorSpellHandler.get_DelveInfo() at DOL.GS.GameInventoryItem.WriteMagicalBonuses(IList`1 output, GameClient client, Boolean shortInfo) at DOL.GS.GameInventoryItem.Delve(List`1 delve, GamePlayer player) at DOL.GS.GamePlayer.DelveItem[T](T item, List`1 delveInfo) at DOL.GS.PacketHandler.Client.v168.DetailDisplayHandler.HandlePacket(GameClient client, GSPacketIn packet) at DOL.GS.PacketHandler.PacketProcessor.HandlePacket(GSPacketIn packet)

Hello whria !

Could you try to compile in debug mode to reproduce this message ? (it lacks line numbers...)

Any particular reason to use SVN 3388 ? Current Version is 3408...

you mean ...

SQLDB serverproperty -> system -> enable_debug -> TRUE

or

compile the execute [DEBUG] in visual studio and use it ?

Compile in Debug in visual Studio (this is needed to track line numbers in stack trace)

1)
I checked multiple error again, here is the error message.

Some people said that there is some trouble in checking the item information , such as " Reactive_Harm_Turning_Tincture " ( after imbue ?). Player can see the item info only by dropping the item into the guild chatting box.

Code: Select all

18:45:15,111 - [21] - ERROR - DOL.GS.PacketHandler.PacketProcessor - Error while processing packet (handler=DOL.GS.PacketHandler.Client.v168.DetailDisplayHandler client: Version1109 pakLib:DOL.GS.PacketHandler.PacketLib1109 type:LabyrinthOfTheMinotaur(LabyrinthOfTheMinotaur) addons:bit4, bit5, Foundations, NewFrontiers state:Playing IP:119.64.40.146:1075 session:21 acc:tiqwnsl2 char:Walker class:12) System.FormatException: Index (zero based) must be greater than or equal to zero and less than the size of the argument list. at System.Text.StringBuilder.AppendFormat(IFormatProvider provider, String format, Object[] args) at System.String.Format(IFormatProvider provider, String format, Object[] args) at System.String.Format(String format, Object[] args) at DOL.GS.Spells.AblativeArmorSpellHandler.get_DelveInfo() in d:\dol\DOLSharp\trunk\GameServer\spells\AblativeArmorSpellHandler.cs:line 195 at DOL.GS.GameInventoryItem.WriteMagicalBonuses(IList`1 output, GameClient client, Boolean shortInfo) in d:\dol\DOLSharp\trunk\GameServer\gameobjects\GameInventoryItem.cs:line 611 at DOL.GS.GameInventoryItem.Delve(List`1 delve, GamePlayer player) in d:\dol\DOLSharp\trunk\GameServer\gameobjects\GameInventoryItem.cs:line 409 at DOL.GS.GamePlayer.DelveItem[T](T item, List`1 delveInfo) in d:\dol\DOLSharp\trunk\GameServer\gameobjects\GamePlayer.cs:line 16114 at DOL.GS.PacketHandler.Client.v168.DetailDisplayHandler.HandlePacket(GameClient client, GSPacketIn packet) in d:\dol\DOLSharp\trunk\GameServer\packets\Client\168\DetailDisplayHandler.cs:line 160 at DOL.GS.PacketHandler.PacketProcessor.HandlePacket(GSPacketIn packet) in d:\dol\DOLSharp\trunk\GameServer\packets\Server\PacketProcessor.cs:line 936

2)
Another question. people said they fail to imbue 4 diffrent items.
I checked spellcrafting.cs line 218.

I think to change the code,
if (bonusToApply.Count >= 4)
-->
if (bonusToApply.Count > 4)

Code: Select all

if (bonusToApply.Count >= 4) { player.Out.SendMessage(LanguageMgr.GetTranslation(player.Client.Account.Language, "SpellCrafting.IsAllowedToCombine.DifferentTypes", item.Name), eChatType.CT_System, eChatLoc.CL_SystemWindow); return false; }

I even think that bug "2)" could be customized using a server property ! (I'll commit something about this until end of the day)

for "1)" I must trace the code with your logs so it can take more time

OK I couldn't set a Server Property that easily, there are tons of "hardcoded" behavior in there (checking the 4 first object bonus slots... be careful with Epic Craft Imbuing, bonus shouldn't be in the firsts slots...)

I just updated to strictly greater than 4 in Revision 3412.