Dawn of Light

Commit from Leodagan

Log Messages:
- Updated : Revamped Access of GamePlayer.DBCharacter to "internal", preventing most interaction with Player Data Object, expecting most of game mechanisms to Use GamePlayer Data Accessors, this will improve the ability to create "Fake" GamePlayer, such as Bots not based on any Database Record (Future Testing/Benchmarking/Scripting Purpose !)
- Updated : Revamped most objects accessing GamePlayer.DBCharacter Object to newly created Data Accessors, preventing any NullPointerException in case of "Fake" Player not Data Based.
- Updated : Fixed Most GamePlayer code Relying on DBCharacter Object to have some default behavior in case of Null Data Object.
- Updated : A lot of Accessors to return default values for missing DBCharacter or prevent exception when setting values.

Files Changed:
MODIFY - /DOLSharp/trunk/GameServer/commands/gmcommands/Ban.cs
MODIFY - /DOLSharp/trunk/GameServer/commands/gmcommands/Player.cs
MODIFY - /DOLSharp/trunk/GameServer/commands/playercommands/freelevel.cs
MODIFY - /DOLSharp/trunk/GameServer/commands/playercommands/friend.cs
MODIFY - /DOLSharp/trunk/GameServer/commands/playercommands/ignore.cs
MODIFY - /DOLSharp/trunk/GameServer/commands/playercommands/level.cs
MODIFY - /DOLSharp/trunk/GameServer/commands/playercommands/respec.cs
MODIFY - /DOLSharp/trunk/GameServer/commands/playercommands/webdisplay.cs
MODIFY - /DOLSharp/trunk/GameServer/effects/GameEffectList.cs
MODIFY - /DOLSharp/trunk/GameServer/effects/GuildBannerEffect.cs
MODIFY - /DOLSharp/trunk/GameServer/gameobjects/CustomNPC/FaceCustomiser.cs
MODIFY - /DOLSharp/trunk/GameServer/gameobjects/CustomNPC/GameTrainer.cs
MODIFY - MODIFY - /DOLSharp/trunk/GameServer/gameobjects/GamePlayer.cs
MODIFY - /DOLSharp/trunk/GameServer/gameobjects/GameTeleporter.cs
MODIFY - /DOLSharp/trunk/GameServer/gameutils/CardMgr.cs
MODIFY - /DOLSharp/trunk/GameServer/gameutils/Faction.cs
MODIFY - /DOLSharp/trunk/GameServer/gameutils/GuildMgr.cs
MODIFY - /DOLSharp/trunk/GameServer/gameutils/PlayerStatistics.cs
MODIFY - /DOLSharp/trunk/GameServer/gameutils/SinglePermission.cs
MODIFY - /DOLSharp/trunk/GameServer/gameutils/XFireSupport.cs
MODIFY - /DOLSharp/trunk/GameServer/housing/House.cs
MODIFY - /DOLSharp/trunk/GameServer/housing/HouseMgr.cs
MODIFY - /DOLSharp/trunk/GameServer/housing/LotMarker.cs
MODIFY - /DOLSharp/trunk/GameServer/packets/Client/168/PlayerInitRequestHandler.cs
MODIFY - /DOLSharp/trunk/GameServer/packets/Client/168/PlayerPositionUpdateHandler.cs
MODIFY - /DOLSharp/trunk/GameServer/packets/Server/PacketLib168.cs
MODIFY - /DOLSharp/trunk/GameServer/packets/Server/PacketLib171.cs
MODIFY - /DOLSharp/trunk/GameServer/propertycalc/FatigueCalculator.cs
MODIFY - /DOLSharp/trunk/GameServer/realmabilities/effects/rr5/AllureofDeadEffect.cs
MODIFY - /DOLSharp/trunk/GameServer/realmabilities/effects/rr5/DreamWeaverEffect.cs
MODIFY - /DOLSharp/trunk/GameServer/realmabilities/effects/rr5/FungalUnionEffect.cs
MODIFY - /DOLSharp/trunk/GameServer/serverrules/AbstractServerRules.cs
MODIFY - /DOLSharp/trunk/GameServer/spells/Masterlevel/Sojourner.cs
MODIFY - /DOLSharp/trunk/GameServer/spells/Teleport/GatewayPersonalBind.cs
MODIFY - /DOLSharp/trunk/GameServerScripts/gameevents/StartupLocations.cs
MODIFY - /DOLSharp/trunk/GameServerScripts/titles/TimeBasedTitle.cs

Realy nice, GG !

/salute !!

So how does one fix custom scripts that are relying on GamePlayer / DBCharacter? For example from the user files: AccountVault, GuildVault, etc? Server crashes on these scripts, see topic: http://www.dolserver.net/viewtopic.php? ... er#p156073

It's exciting that we're in this together. Really helpful