Page 1 of 1

Mythical Stat Bonuses

PostPosted: Wed Jun 15, 2016 8:39 am
by dargon
I added Mythical Stat Bonuses to my server.

With the switch to git, it seems i cant make patches, but here are my modified files.
in global constants.cs i just used the unused properties 136-142 to add Mythical____CapBonus ___=Stat

In property Calc i added some new lines to get the maximum mythical cap bonus (Live Like of 52) and some math changes to make the normal cap + mythical cap not go over 52

skillbase just adds the names for when you info an item with the bonus.
The only issue with this addition, is I could not find where to make it so it can show 127/127. It will only show 101/101 then give a buff bonus of +26. I am currently looking to find it and fix it, but the mythical stat bonuses DO work if anyone would like them

Re: Mythical Stat Bonuses

PostPosted: Wed Jun 15, 2016 12:29 pm
by Graveen
Hello Dargon,
With the switch to GIT, you must open an account on github.com, fork DOL, change and submit a pull request via github.
For diffs, you can still use TortoiseGIT or whatever for diffing files (winmerge can do it too).

Interesting changes, thank you !

Re: Mythical Stat Bonuses

PostPosted: Wed Jun 15, 2016 7:06 pm
by dargon
ill attempt to do that. Mythocal bonuses were a nice addition on live that makes useful additions on my custom shard as well as nice pluses on decent rvr shard imo

Re: Mythical Stat Bonuses

PostPosted: Thu Jun 16, 2016 4:21 pm
by Graveen
/cheer :)

Re: Mythical Stat Bonuses

PostPosted: Mon Jun 20, 2016 5:55 pm
by dargon
I believe i made the changes to my branch on github for review, still getting used to it haha.

Link to my github: https://github.com/Mannik/DOLSharp/
Any changes I see useful for DOL public releases i will attempt to send here.

Re: Mythical Stat Bonuses

PostPosted: Wed Jun 22, 2016 9:48 pm
by Graveen
Yes this is the best.
Thank you VM

Re: Mythical Stat Bonuses

PostPosted: Thu May 16, 2019 12:44 pm
by Eyebalze
Hey guys,

sorry for re-capturing this topic, but are the changes for the mythical stat bonuses already implented with the current revision release on DOLSharp? or do i have to insert them manually?!

Thanks for your answers.

Best regards
Eyebalze

Re: Mythical Stat Bonuses

PostPosted: Sat May 18, 2019 9:05 am
by Graveen
IIRC they are :)

Re: Mythical Stat Bonuses

PostPosted: Mon May 20, 2019 7:39 am
by Eyebalze
IIRC they are :)
Thanks alot Graveen!

Re: Mythical Stat Bonuses

PostPosted: Fri Jul 05, 2019 1:53 am
by dargon
unless someone has looked at it since i put them in, i cant say they're very clean or well built, but they are in and do work lmao

Re: Mythical Stat Bonuses

PostPosted: Fri Jul 05, 2019 8:02 am
by Eyebalze
unless someone has looked at it since i put them in, i cant say they're very clean or well built, but they are in and do work lmao
Alright, thanks for the declaration!
Br. Eyebalze